Problem after upgrading from v7.3.4 to v7.4

[rodrigocoelho]

Current version is 7.3.4.
EspoCRM will be upgraded to version 7.4.0 now. Enter [Y] to continue.
y
This may take a while. Do not close the terminal.
Downloading...
Upgrading...
Initialization...
Copying before upgrade files...
Rebuilding...
Before upgrade script execution...
Rebuilding...
Copying files...
Rebuilding...
Reverting...
Unknown error on shell_exec.

After that, it is not loading anymore, always giving Error 500

[rodrigocoelho]

[2023-04-06 14:35:45] WARNING: E_WARNING: Undefined array key "type" {"code":2,"message":"Undefined array key \"type\"","file":"/var/www/html/espocrm/application/Espo/Core/Utils/Database/Orm/RelationConverter.php","line":90}
[2023-04-06 14:35:45] ERROR: Slim Application Error Type: TypeError Code: 0 Message: Espo\Core\Utils\Database\Orm\RelationConverter::createLinkConverter(): Argument #2 ($type) must be of type string, null given, called in /var/www/html/espocrm/application/Espo/Core/Utils/Database/Orm/RelationConverter.php on line 98 File: /var/www/html/espocrm/application/Espo/Core/Utils/Database/Orm/RelationConverter.php Line: 112 Trace: #0 /var/www/html/espocrm/application/Espo/Core/Utils/Database/Orm/RelationConverter.php(98): Espo\Core\Utils\Database\Orm\RelationConverter->createLinkConverter(NULL, NULL, NULL) #1 /var/www/html/espocrm/application/Espo/Core/Utils/Database/Orm/Converter.php(621): Espo\Core\Utils\Database\Orm\RelationConverter->process('quotes', Array, 'Account', Array) #2 /var/www/html/espocrm/application/Espo/Core/Utils/Database/Orm/Converter.php(210): Espo\Core\Utils\Database\Orm\Converter->convertLinks('Account', Array, Array) #3 /var/www/html/espocrm/application/Espo/Core/Utils/Database/Orm/Converter.php(159): Espo\Core\Utils\Database\Orm\Converter->convertEntity('Account', Array) #4 /var/www/html/espocrm/application/Espo/Core/Utils/Metadata/OrmMetadataData.php(100): Espo\Core\Utils\Database\Orm\Converter->process() #5 /var/www/html/espocrm/application/Espo/Core/Utils/Metadata/OrmMetadataData.php(79): Espo\Core\Utils\Metadata\OrmMetadataData->getDataInternal() #6 /var/www/html/espocrm/application/Espo/Core/ORM/MetadataDataProvider.php(52): Espo\Core\Utils\Metadata\OrmMetadataData->getData() #7 /var/www/html/espocrm/application/Espo/ORM/Metadata.php(52): Espo\Core\ORM\MetadataDataProvider->get() #8 /var/www/html/espocrm/application/Espo/Core/ORM/EntityManagerFactory.php(80): Espo\ORM\Metadata->__construct(Object(Espo\Core\ORM\MetadataDataProvider), Object(Espo\ORM\EventDispatcher)) #9 /var/www/html/espocrm/application/Espo/Core/Loaders/EntityManager.php(49): Espo\Core\ORM\EntityManagerFactory->create() #10 /var/www/html/espocrm/application/Espo/Core/Container.php(336): Espo\Core\Loaders\EntityManager->load() #11 /var/www/html/espocrm/application/Espo/Core/Container.php(101): Espo\Core\Container->load('entityManager') #12 /var/www/html/espocrm/application/Espo/Core/InjectableFactory.php(331): Espo\Core\Container->get('entityManager') #13 /var/www/html/espocrm/application/Espo/Core/InjectableFactory.php(269): Espo\Core\InjectableFactory->resolveBinding(Object(Espo\Core\Binding\Binding), NULL) #14 /var/www/html/espocrm/application/Espo/Core/InjectableFactory.php(211): Espo\Core\InjectableFactory->getMethodParamInjection(Object(ReflectionClass), Object(ReflectionParameter), NULL, NULL) #15 /var/www/html/espocrm/application/Espo/Core/InjectableFactory.php(173): Espo\Core\InjectableFactory->getConstructorInjectionList(Object(ReflectionClass), NULL, NULL) #16 /var/www/html/espocrm/application/Espo/Core/InjectableFactory.php(73): Espo\Core\InjectableFactory->createInternal('Espo\\Core\\Authe...') #17 /var/www/html/espocrm/application/Espo/Core/Container.php(365): Espo\Core\InjectableFactory->create('Espo\\Core\\Authe...') #18 /var/www/html/espocrm/application/Espo/Core/Container.php(101): Espo\Core\Container->load('authTokenManage...') #19 /var/www/html/espocrm/application/Espo/Core/InjectableFactory.php(331): Espo\Core\Container->get('authTokenManage...') #20 /var/www/html/espocrm/application/Espo/Core/InjectableFactory.php(269): Espo\Core\InjectableFactory->resolveBinding(Object(Espo\Core\Binding\Binding), NULL) #21 /var/www/html/espocrm/application/Espo/Core/InjectableFactory.php(211): Espo\Core\InjectableFactory->getMethodParamInjection(Object(ReflectionClass), Object(ReflectionParameter), NULL, NULL) #22 /var/www/html/espocrm/application/Espo/Core/InjectableFactory.php(173): Espo\Core\InjectableFactory->getConstructorInjectionList(Object(ReflectionClass), NULL, NULL) #23 /var/www/html/espocrm/application/Espo/Core/InjectableFactory.php(73): Espo\Core\InjectableFactory->createInternal('Espo\\Core\\Authe...') #24 /var/www/html/espocrm/application/Espo/Core/Authentication/AuthenticationFactory.php(41): Espo\Core\InjectableFactory->create('Espo\\Core\\Authe...') #25 /var/www/html/espocrm/application/Espo/Core/Api/RouteProcessor.php(111): Espo\Core\Authentication\AuthenticationFactory->create() #26 /var/www/html/espocrm/application/Espo/Core/Api/RouteProcessor.php(78): Espo\Core\Api\RouteProcessor->processInternal(Object(Espo\Core\Api\ProcessData), Object(Slim\Psr7\Request), Object(Espo\Core\Api\RequestWrapper), Object(Espo\Core\Api\ResponseWrapper)) #27 /var/www/html/espocrm/application/Espo/Core/Api/Starter.php(109): Espo\Core\Api\RouteProcessor->process(Object(Espo\Core\Api\ProcessData), Object(Slim\Psr7\Request), Object(Slim\Psr7\Response)) #28 /var/www/html/espocrm/vendor/slim/slim/Slim/Handlers/Strategies/RequestResponse.php(38): Espo\Core\Api\Starter->Espo\Core\Api\{closure}(Object(Slim\Psr7\Request), Object(Slim\Psr7\Response), Array) #29 /var/www/html/espocrm/vendor/slim/slim/Slim/Routing/Route.php(358): Slim\Handlers\Strategies\RequestResponse->__invoke(Object(Closure), Object(Slim\Psr7\Request), Object(Slim\Psr7\Response), Array) #30 /var/www/html/espocrm/vendor/slim/slim/Slim/MiddlewareDispatcher.php(65): Slim\Routing\Route->handle(Object(Slim\Psr7\Request)) #31 /var/www/html/espocrm/vendor/slim/slim/Slim/MiddlewareDispatcher.php(65): Slim\MiddlewareDispatcher->handle(Object(Slim\Psr7\Request)) #32 /var/www/html/espocrm/vendor/slim/slim/Slim/Routing/Route.php(315): Slim\MiddlewareDispatcher->handle(Object(Slim\Psr7\Request)) #33 /var/www/html/espocrm/vendor/slim/slim/Slim/Routing/RouteRunner.php(68): Slim\Routing\Route->run(Object(Slim\Psr7\Request)) #34 /var/www/html/espocrm/vendor/slim/slim/Slim/Middleware/RoutingMiddleware.php(45): Slim\Routing\RouteRunner->handle(Object(Slim\Psr7\Request)) #35 /var/www/html/espocrm/vendor/slim/slim/Slim/MiddlewareDispatcher.php(121): Slim\Middleware\RoutingMiddleware->process(Object(Slim\Psr7\Request), Object(Slim\Routing\RouteRunner)) #36 /var/www/html/espocrm/vendor/slim/slim/Slim/Middleware/ErrorMiddleware.php(76): Psr\Http\Server\RequestHandlerInterface@anonymous->handle(Object(Slim\Psr7\Request)) #37 /var/www/html/espocrm/vendor/slim/slim/Slim/MiddlewareDispatcher.php(121): Slim\Middleware\ErrorMiddleware->process(Object(Slim\Psr7\Request), Object(Psr\Http\Server\RequestHandlerInterface@anonymous)) #38 /var/www/html/espocrm/vendor/slim/slim/Slim/MiddlewareDispatcher.php(65): Psr\Http\Server\RequestHandlerInterface@anonymous->handle(Object(Slim\Psr7\Request)) #39 /var/www/html/espocrm/vendor/slim/slim/Slim/App.php(199): Slim\MiddlewareDispatcher->handle(Object(Slim\Psr7\Request)) #40 /var/www/html/espocrm/vendor/slim/slim/Slim/App.php(183): Slim\App->handle(Object(Slim\Psr7\Request)) #41 /var/www/html/espocrm/application/Espo/Core/Api/Starter.php(76): Slim\App->run() #42 /var/www/html/espocrm/application/Espo/Core/ApplicationRunners/Api.php(45): Espo\Core\Api\Starter->start() #43 /var/www/html/espocrm/application/Espo/Core/Application/RunnerRunner.php(87): Espo\Core\ApplicationRunners\Api->run() #44 /var/www/html/espocrm/application/Espo/Core/Application.php(78): Espo\Core\Application\RunnerRunner->run('Espo\\Core\\Appli...', NULL) #45 /var/www/html/espocrm/public/api/v1/index.php(37): Espo\Core\Application->run('Espo\\Core\\Appli...') #46 {main} Tips: To display error details in HTTP response set "displayErrorDetails" to true in the ErrorHandler constructor.
[2023-04-06 14:36:04] WARNING: E_WARNING: Undefined array key "type" {"code":2,"message":"Undefined array key \"type\"","file":"/var/www/html/espocrm/application/Espo/Core/Utils/Database/Orm/RelationConverter.php","line":90}
[2023-04-06 14:36:04] ERROR: Uncaught Exception TypeError: "Espo\Core\Utils\Database\Orm\RelationConverter::createLinkConverter(): Argument #2 ($type) must be of type string, null given, called in /var/www/html/espocrm/application/Espo/Core/Utils/Database/Orm/RelationConverter.php on line 98" at /var/www/html/espocrm/application/Espo/Core/Utils/Database/Orm/RelationConverter.php line 112 {"exception":"[object] (TypeError(code: 0): Espo\\Core\\Utils\\Database\\Orm\\RelationConverter::createLinkConverter(): Argument #2 ($type) must be of type string, null given, called in /var/www/html/espocrm/application/Espo/Core/Utils/Database/Orm/RelationConverter.php on line 98 at /var/www/html/espocrm/application/Espo/Core/Utils/Database/Orm/RelationConverter.php:112)"}
[2023-04-06 14:36:31] WARNING: E_WARNING: Undefined array key "type" {"code":2,"message":"Undefined array key \"type\"","file":"/var/www/html/espocrm/application/Espo/Core/Utils/Database/Orm/RelationConverter.php","line":90}
[2023-04-06 14:36:31] ERROR: Uncaught Exception TypeError: "Espo\Core\Utils\Database\Orm\RelationConverter::createLinkConverter(): Argument #2 ($type) must be of type string, null given, called in /var/www/html/espocrm/application/Espo/Core/Utils/Database/Orm/RelationConverter.php on line 98" at /var/www/html/espocrm/application/Espo/Core/Utils/Database/Orm/RelationConverter.php line 112 {"exception":"[object] (TypeError(code: 0): Espo\\Core\\Utils\\Database\\Orm\\RelationConverter::createLinkConverter(): Argument #2 ($type) must be of type string, null given, called in /var/www/html/espocrm/application/Espo/Core/Utils/Database/Orm/RelationConverter.php on line 98 at /var/www/html/espocrm/application/Espo/Core/Utils/Database/Orm/RelationConverter.php:112)"}​

[yuri]

You have some link w/o the type. In entityDefs.

[yuri]

You can apply this commit https://github.com/espocrm/espocrm/c...fb9cf584ab0318. It will print the problem link to the log.

[yuri]

Didn't you run in a single process mode? -s parameter. It could be a reason your instance is not reverted.

[rodrigocoelho]

You have some link w/o the type. In entityDefs.

Contact_role inside accounts.json??? If so, What should I use as type in there?

{
    "fields": {
        "inscricaoMunicipal": {
            "type": "varchar",
            "required": false,
            "trim": true,
            "maxLength": 30,
            "audited": true,
            "isCustom": true
        },
        "sicCode": {
            "type": "varchar",
            "maxLength": 40,
            "trim": true,
            "default": "xx.xxx.xxx/0001-xx",
            "required": false,
            "audited": true
        },
        "razaosocial": {
            "type": "varchar",
            "required": false,
            "trim": true,
            "maxLength": 200,
            "audited": true,
            "isCustom": true
        },
        "aimsun": {
            "type": "linkMultiple",
            "layoutDetailDisabled": false,
            "layoutListDisabled": true,
            "layoutMassUpdateDisabled": false,
            "noLoad": false,
            "importDisabled": false,
            "isCustom": true
        },
        "projects": {
            "type": "linkMultiple",
            "layoutDetailDisabled": false,
            "layoutListDisabled": true,
            "layoutMassUpdateDisabled": false,
            "importDisabled": false,
            "noLoad": false,
            "isCustom": true
        },
        "orgaoPublico": {
            "notNull": true,
            "type": "bool",
            "audited": false,
            "tooltipText": "Órgão Publico, incluindo universidades",
            "default": false,
            "readOnly": false,
            "tooltip": true,
            "isCustom": true
        },
        "contactRole": {
            "required": false,
            "trim": false,
            "audited": false,
            "readOnly": false,
            "tooltip": false
        },
        "opportunities1": {
            "layoutListDisabled": true,
            "layoutDetailDisabled": false,
            "type": "linkMultiple",
            "layoutMassUpdateDisabled": false,
            "importDisabled": false,
            "noLoad": false,
            "isCustom": true,
            "orderBy": "createdAt",
            "enableForm": true,
            "fields": [
                "name",
                "stage"
            ],
            "layout": "custom",
            "order": "asc"
        },
        "financeiros": {
            "type": "linkMultiple",
            "layoutDetailDisabled": false,
            "layoutMassUpdateDisabled": false,
            "importDisabled": false,
            "noLoad": false,
            "isCustom": true
        },
        "aRTs": {
            "type": "linkMultiple",
            "layoutDetailDisabled": false,
            "layoutMassUpdateDisabled": false,
            "noLoad": false,
            "importDisabled": false,
            "isCustom": true
        },
        "medicoes": {
            "type": "linkMultiple",
            "layoutDetailDisabled": false,
            "layoutMassUpdateDisabled": false,
            "importDisabled": false,
            "noLoad": false,
            "isCustom": true
        },
        "pesquisas": {
            "type": "linkMultiple",
            "layoutDetailDisabled": false,
            "layoutMassUpdateDisabled": false,
            "importDisabled": false,
            "noLoad": false,
            "isCustom": true
        },
        "pontosDePesquisas": {
            "type": "linkMultiple",
            "layoutDetailDisabled": false,
            "layoutMassUpdateDisabled": false,
            "importDisabled": false,
            "noLoad": false,
            "isCustom": true
        },
        "tasks1": {
            "type": "linkMultiple",
            "layoutDetailDisabled": true,
            "layoutMassUpdateDisabled": true,
            "importDisabled": true,
            "noLoad": true,
            "isCustom": true
        }
    },
    "links": {
        "aimsun": {
            "type": "hasMany",
            "foreign": "account",
            "entity": "Aimsun",
            "isCustom": true
        },
        "projects": {
            "type": "hasMany",
            "relationName": "projectAccount",
            "foreign": "accounts",
            "entity": "Project",
            "isCustom": true,
            "audited": true
        },
        "quotes": {
            "audited": false
        },
        "opportunities": {
            "audited": true
        },
        "opportunities1": {
            "type": "hasMany",
            "relationName": "opportunityAccount",
            "foreign": "accounts",
            "entity": "Opportunity",
            "audited": true,
            "isCustom": true
        },
        "financeiros": {
            "type": "hasMany",
            "relationName": "financeiroAccount",
            "foreign": "accounts",
            "entity": "Financeiro",
            "audited": true,
            "isCustom": true
        },
        "aRTs": {
            "type": "hasMany",
            "foreign": "empresa",
            "entity": "ARTs",
            "audited": false,
            "isCustom": true
        },
        "medicoes": {
            "type": "hasMany",
            "relationName": "medicoesAccount",
            "foreign": "empresas",
            "entity": "Medicoes",
            "audited": true,
            "isCustom": true
        },
        "pesquisas": {
            "type": "hasMany",
            "relationName": "pesquisasAccount",
            "foreign": "accounts",
            "entity": "Pesquisas",
            "audited": true,
            "isCustom": true
        },
        "pontosDePesquisas": {
            "type": "hasMany",
            "relationName": "pontosDePesquisaAccount",
            "foreign": "accounts",
            "entity": "PontosDePesquisa",
            "audited": true,
            "isCustom": true
        },
        "tasks1": {
            "type": "hasMany",
            "relationName": "taskAccount",
            "foreign": "accounts",
            "entity": "Task",
            "audited": true,
            "isCustom": true
        }
    },
    "collection": {
        "sortBy": "name",
        "asc": true,
        "textFilterFields": [
            "name"
        ],
        "filters": {
            "reportFilter5ab280a0cb5bc135a": {
                "isReportFilter": true,
                "className": "Espo\\Modules\\Advanced\\Core\\ReportFilter",
                "id": "5ab280a0cb5bc135a"
            }
        },
        "orderBy": "createdAt",
        "order": "desc",
        "fullTextSearch": true,
        "countDisabled": false
    },
    "optimisticConcurrencyControl": false
}​

[yuri]

Try to replace the file application/Espo/Core/Utils/Database/Orm/RelationConverter.php with

https://raw.githubusercontent.com/espocrm/espocrm/fix/application/Espo/Core/Utils/Database/Orm/RelationConverter.php

Then rebuild.

[rodrigocoelho]

I did, I found a quotes link inside accounts.json. Removed it (don't use it).
Now, it is giving this in log:
[2023-04-06 16:28:21] ERROR: Uncaught Exception RuntimeException: "Unsupported link type 'datetime'." at /var/www/html/espocrm/application/Espo/Core/Utils/Database/Orm/RelationConverter.php line 162 {"exception":"[object] (RuntimeException(code: 0): Unsupported link type 'datetime'. at /var/www/html/espocrm/application/Espo/Core/Utils/Database/Orm/RelationConverter.php:162)"}

I can't find where this link type is being used.

[rodrigocoelho]

Ok, found datetime in several custom json. What should be used in place?

[yuri]

try running

grep -R '"datetime"' custom/Espo/Custom/Resources

[yuri]

I've no idea. Remove these links (if they are really links but not fields).

[rodrigocoelho]

try running

grep -R '"datetime"' custom/Espo/Custom/Resources

something weird.

 grep -R '"datetime"' custom/Espo/Custom/Resources
custom/Espo/Custom/Resources/metadata/entityDefs/Inventario.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/Inventario.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/Aimsun.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/Aimsun.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/Medicoes.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/Medicoes.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/Financeiro.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/Financeiro.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/ARTs.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/ARTs.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/Treinamento.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/Treinamento.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/Treinamento.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/Treinamento.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/Pesquisas.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/Pesquisas.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/GoogleSheets.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/GoogleSheets.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/Caixinha.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/Caixinha.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/Opportunity.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/PontosDePesquisa.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/PontosDePesquisa.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/Project.json:            "type": "datetime",
custom/Espo/Custom/Resources/metadata/entityDefs/Project.json:            "type": "datetime",​

[yuri]

There's datetime field type which is legit.

[rodrigocoelho]

found it.

now, another error.

[2023-04-06 16:46:11] ERROR: Uncaught Exception RuntimeException: "No 'midKey' parameter defined in the relation 'aimsuns'." at /var/www/html/espocrm/application/Espo/ORM/Defs/RelationDefs.php line 233 {"exception":"[object] (RuntimeException(code: 0): No 'midKey' parameter defined in the relation 'aimsuns'. at /var/www/html/espocrm/application/Espo/ORM/Defs/RelationDefs.php:233)"}

[rodrigocoelho]

root@server-AWS-LS ~/p/espocrm# grep -R 'aimsuns' custom/Espo/Custom/Resources
custom/Espo/Custom/Resources/i18n/pt_BR/Contact.json:        "aimsuns": "Aimsun",
custom/Espo/Custom/Resources/i18n/pt_BR/Contact.json:        "aimsuns": "Aimsun"
custom/Espo/Custom/Resources/i18n/pt_BR/User.json:        "aimsuns": "Aimsuns",
custom/Espo/Custom/Resources/i18n/pt_BR/User.json:        "aimsuns": "Aimsuns",
custom/Espo/Custom/Resources/i18n/en_US/Contact.json:        "aimsuns": "Aimsuns novo",
custom/Espo/Custom/Resources/i18n/en_US/Contact.json:        "aimsuns": "Aimsuns novo"
custom/Espo/Custom/Resources/layouts/User/relationships.json:        "name": "aimsuns"
custom/Espo/Custom/Resources/layouts/User/bottomPanelsDetail.json:    "aimsuns": {
custom/Espo/Custom/Resources/layouts/Contact/massUpdate.json:    "aimsuns",
custom/Espo/Custom/Resources/layouts/Contact/relationships.json:        "name": "aimsuns"
custom/Espo/Custom/Resources/layouts/Contact/sidePanelsDetail.json:                    "attribute": "aimsunsIds",
custom/Espo/Custom/Resources/layouts/Contact/sidePanelsDetail.json:                        "field": "aimsuns"
custom/Espo/Custom/Resources/layouts/Contact/listSmall.json:        "name": "aimsuns"
custom/Espo/Custom/Resources/layouts/Contact/detail.json:                    "name": "aimsuns"
custom/Espo/Custom/Resources/layouts/Contact/filters.json:    "aimsuns",
custom/Espo/Custom/Resources/metadata/entityDefs/Contact.json:        "aimsuns": {
custom/Espo/Custom/Resources/metadata/entityDefs/Contact.json:        "aimsuns": {
custom/Espo/Custom/Resources/metadata/entityDefs/Aimsun.json:            "foreign": "aimsuns",
custom/Espo/Custom/Resources/metadata/entityDefs/User.json:        "aimsuns": {
custom/Espo/Custom/Resources/metadata/entityDefs/User.json:        "aimsuns": {​