Quotes: Problems with PDF Creation

[tobias]

We currently face the following issues:

1. <p style="margin-top:6em;"> is being ignored (i.e., no top margin printed on PDF)
2. {{#if lead.salutationName == 'foo'}}foo{{/if}} is always true (i.e., "foo" always printed on PDF)
3. <p style="font-family:'Open Sans'> is being ignored (i.e., default font family printed on PDF)

Your help is much appreciated.

[tobias]

We sorted out 1) by using simple line-breaks.
We accept 3) since Open Sans is not supported by the core version of TCPDF (https://tcpdf.org/docs/fonts/).

This leaves us with 2) and that's really important for business communication in German language.

Any ideas?

[tanya]

Hello

{{#if}} checks only, if parameter is not empty (false, undefined, null, "", 0, or [])

[tobias]

Ok, and how can we check if lead.salutationName == 'foo' in a template?

[tanya]

As I see, it needs some development

https://www.abeautifulsite.net/an-ifcond-block-helper-for-lightncandy

https://github.com/zordius/lightncandy#detail-feature-list

[tobias]

Ok, so what you suggest is to update application/Espo/Core/Htmlizer/Htmlizer.php as follows.

Old:

      $code = \LightnCandy::compile($template, [
            'helpers' => [
                'file' => function ($context, $options) {
                    if (count($context) && $context[0]) {
                        $id = $context[0];
                        return "?entryPoint=attachment&id=" . $id;
                    }
                }
            ]
        ]);

New:

        $code = \LightnCandy::compile($template, [
            'helpers' => [
                'file' => function ($context, $options) {
                    if (count($context) && $context[0]) {
                        $id = $context[0];
                        return "?entryPoint=attachment&id=" . $id;
                    }
                },
                'ifcond' => function() {
                    // Get arguments
                    $args = func_get_args();
                    $context = $args[count($args) - 1];
                    if( (string) $args[0] === (string) $args[1] ) {
                        // Arguments match, render it
                        return $context['fn']();
                    } else {
                        // If an {{else}} exists, render that instead; otherwise, render nothing
                        return $context['inverse'] ? $context['inverse']() : '';
                    }
                }
            ]
        ]);

[tanya]

This solution is not upgrade safe. Check, if this file wasn't touched with each upgrade. Maybe this functionality will be add in the future (not sure about the name of function will be the same as yours)

[tobias]

Any ideas how to make this patch upgrade safe?

We really need this to work to properly generate our business documents (quotes, invoices etc.). So if there's no other way, we need to check/re-patch with every update.

[tanya]

No simple way... You can create own pdf builder, extends existing one. Too many manipulation for this... You upgrade crm not so often... For now easier to check, if file was changed. it's not so big probability, that file was modified in an upgrade

[tobias]

We've added the above code. However, the template would ignore the following code:

{{#ifcond lead.salutationName 'foo'}}foo{{/ifcond}}

Any suggestions?

[tobias]

Sorry to push again, but we really need this to work.

How would you call your own custom function "file" in a template? This should be the same as our custom function "ifcond", right?

[tanya]

From the next version will be available ifEqual and IfNotEqual helpers
https://github.com/espocrm/espocrm/c...80a319fdeb7b91

[tobias]

Works a treat - thanks so much