bug to consider

[arturkulik]

Hi,
for a couple of weeks we get occasional critical error on images:

original version of this error was without path and type just No width or height, we edited one file to get more info anout error and this is what we found:




it takes place when Espo tries generate thumbnail in size medium on case or email (for sure on other entities displaying images like thumbs) containing attachment like:



small file with few pixel of height

and the effect is no preview but img links:


So to continue:


should we consider it like a bug and for example stop creating thumbs when original images has smaller dimensions than thumbnail?

[yuri]

Can you provide with a sample image to reproduce? I could not reproduce with an image smaller than a thumb size.

[yuri]

It could happen if the the width to height ratio is very large. Like width 512, height is 2. Is it your case?

[yuri]

Fix: https://github.com/espocrm/espocrm/c...4e8c2e0ee7c72a

[yuri]

Making it as a link but not preview is bit trickier. We don't know the real size of the image before it's rendered.

[arturkulik]

thank You, we fixed that but it will be valid till next espo update

i attached one example file



with error like

[yuri]

With the fix, it displays for me like this:



The is a generous padding area around the thin image, hence it's easily clickable.

[arturkulik]

With the fix, it displays for me like this:



The is a generous padding area around the thin image, hence it's easily clickable.

thank You, will it be included in further Espo builds