DefaultAssignmentChecker error

[a.slyzhko]

Hi! I have noticed strange thing, when assigning a user to any entity. I'm testing my application with user with team assignment rights. And I get the followind error after clicking Save button.

ERROR: Slim Application Error Type: TypeError Code: 0 Message: Espo\Repositories\User::checkBelongsToAnyOfTeams(): Argument #2 ($teamIds) must be of type array, null given, called in /var/www/espocrm/application/Espo/Core/Acl/DefaultAssignmentChecker.php on line 147

When application reaches this block

else if ($assignmentPermission === Table::LEVEL_TEAM) {
    $teamIdList = $user->get(self::ATTR_TEAMS_IDS);
        if (!$this->getUserRepository()->checkBelongsToAnyOfTeams($assignedUserId, $teamIdList)) {
            return false;
        }
}​ 

Somehow, the teamIds are not being fetched from the database when the user entity is injected into the Acl of user record service. Any ideas?

[yuri]

Use getTeamIdList.

[a.slyzhko]

Thanks! Your solution is actually the same as mine. Will you replace this in the following updates?

[a.slyzhko]

I resolved this issue by replacing $user->get method call

$teamIdList = $user->get(self::ATTR_TEAMS_IDS); 

with this method call

$teamIdList = $user->getLinkMultipleIdList(self::FIELD_TEAMS); 

As this is core, I think developers should replace this in the following updates.

[yuri]

How do you create a record service?

[a.slyzhko]

I'm using default one. This is PUT requst from UI. No custom logic applied

[yuri]

It's weird, as this issue should have been detected, this code is tested and it's been for years as it is. I assume it works fine on an out-of-the-box instance.

Just want to figure out why it happens on your instance.

This code should load teams for authenticated user: https://github.com/espocrm/espocrm/b...ation.php#L221

[a.slyzhko]

I'm admin and I'm logged in as regular user in incognito tab. Can this cause the issue?

[yuri]

Yes, reproduced when logged as another user. We will need to fix both, Assignment Checker and loading teams when logged as another user.

[yuri]

I'll fix it for v8.1. Thanks for help.

[a.slyzhko]

Great! I'm glad to help. It's my pleasure.