Forwarded emails do not include attachments

[inactum]

After the upgrade to version 7.0.9 we found that email attachments are not being attached and sent with the forwarded emails. If I click on Forward button, the email is placed to the email form, but the attachment is not included (it does not matter if it is a picture file or a document one). When the email is sent, the forwarded email does not include the attachment.
We upgraded to EspoCRM 7.0.9 on January 30th, 2022. Problems with the email started immediately after the upgrade.

[yuri]

https://github.com/espocrm/espocrm/issues/2226

[chr1st0ph9]

Bonjour,
I installed successfully the 7.0.10 (with .../command.php upgrade -y ..) but unfortunately no improvement concerning the pb:

• Forward email not copying attachments #2226

Did I made smth wrong or missed smth?
---
Salutations amicales de France

[item]

Salut,
je crois que :

https://github.com/espocrm/espocrm/commit/5c47b6c6532580dfd00c721c3f4ae6a10fd5c27c

peut-tu essayer et feedback ?

Salutation from Belgium

[yuri]

No! This fix is for 7.1.0 and not related to this issue.

[yuri]

It works on a few instances I tested.

[chr1st0ph9]

Thanks for your feedback,
I tried to edit client/src/views/email/detail.js following https://github.com/espocrm/espocrm/c...4ae6a10fd5c27c then made the modifications below:

< attributes['attachmentsIds'] = duplicateAttributes.ids;
< attributes['attachmentsNames'] = duplicateAttributes.names;
---
> attributes['attachmentsIds'] = data.ids;
> attributes['attachmentsNames'] = data.names;

and it works :-)

However, the source code on my machine

var attributes = emailHelper.getForwardAttributes(this.model, data, cc);^M

this.notify('Loading...');
Espo.Ajax
.postRequest('Email/action/getCopiedAttachments', {
id: this.model.id,
})
.then(data => {
attributes['attachmentsIds'] = duplicateAttributes.ids;
attributes['attachmentsNames'] = duplicateAttributes.names;


is different from https://github.com/espocrm/espocrm/c...4ae6a10fd5c27c even if espocrm should be up to date on my machine.
---
Salutations amicales de France

[yuri]

It's supposed to be different, as master is not stable. Check the stable branch.

[chr1st0ph9]

Merci Yuri