Problem with format of Invitation emails

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • yuri
    Member
    • Mar 2014
    • 8557

    #16
    Hi Philipp

    Thank you for your help. I made some changes but would like to check whether it works now. Can you send me your email address in Private Message. Then I will send you an Invitation email from our dev version.
    If you find EspoCRM good, we would greatly appreciate if you could give the project a star on GitHub. We believe our work truly deserves more recognition. Thanks.

    Comment

    • Philipp
      Junior Member
      • Aug 2014
      • 20

      #17
      Hi,

      looks perfect on Gmail and Outlook now. Thank you!

      Click image for larger version

Name:	test1.PNG
Views:	123
Size:	13.3 KB
ID:	1749

      Click image for larger version

Name:	test2.PNG
Views:	115
Size:	50.0 KB
ID:	1750

      When will it be possible to see if someone accepted or declined?

      Kind regards,
      Philipp

      Comment

      • alasdaircr
        Active Community Member
        • Aug 2014
        • 525

        #18
        I made some modifications of the code so that Accepted / Declined is shown. I can tidy it up and post it soon.

        Yuri could you post the diff that fixes this problem?

        Comment

        • yuri
          Member
          • Mar 2014
          • 8557

          #19
          Hi

          Not sure whether it fixed the problem since this email was sent from me.

          application/Espo/Core/Mail/Sender.php
          application/Espo/Entities/Email.php

          Last edited by yuri; 09-02-2014, 07:22 AM.
          If you find EspoCRM good, we would greatly appreciate if you could give the project a star on GitHub. We believe our work truly deserves more recognition. Thanks.

          Comment

          • alasdaircr
            Active Community Member
            • Aug 2014
            • 525

            #20
            Sorry Yuri it doesn't fix it for me on my local installation.

            Comment

            • Philipp
              Junior Member
              • Aug 2014
              • 20

              #21
              Hi,

              I just upgraded to 2.5.1, but this problem is not solved in that version.
              Can I help you with some testing?

              Kind regards
              Philipp

              Comment

              • yuri
                Member
                • Mar 2014
                • 8557

                #22
                Hi

                Can you send invitation email to me. I've sent my email in PM

                Thanks
                If you find EspoCRM good, we would greatly appreciate if you could give the project a star on GitHub. We believe our work truly deserves more recognition. Thanks.

                Comment

                • alasdaircr
                  Active Community Member
                  • Aug 2014
                  • 525

                  #23
                  I can send one to you yuri if you want.

                  Comment

                  • yuri
                    Member
                    • Mar 2014
                    • 8557

                    #24
                    Still haven't solved this issue. The problem that i can't reproduce on our instances.
                    Could somebody who has this problem edit file application/Espo/Modules/Crm/Business/Event/Invitations.php
                    change $email->set('body', $body); to $email->set('body', '<b>test</b>');

                    And then check if email is received correctly formatted.
                    If you find EspoCRM good, we would greatly appreciate if you could give the project a star on GitHub. We believe our work truly deserves more recognition. Thanks.

                    Comment

                    • alasdaircr
                      Active Community Member
                      • Aug 2014
                      • 525

                      #25
                      Hi I just tried this and still not working. Has to be with the way the attachment is added / in what order / or how the email is being formed which is different to the method in compose email.

                      I know I said I'd have a look but have been busy. I'll have a step through the code tomorrow.

                      Comment

                      • alasdaircr
                        Active Community Member
                        • Aug 2014
                        • 525

                        #26
                        Found it! Thanks for the help Yuri.

                        The problem is the subject, not the body of the email. If I set subject to some plain text then the email is formatted correctly. I wonder what is wrong /different about the template?

                        Comment

                        • alasdaircr
                          Active Community Member
                          • Aug 2014
                          • 525

                          #27
                          There's a carriage return in the $subject returned from parseInvitiationTemplate, that's the problem. I just debug printed it and there's new line showing in the log

                          Comment

                          • alasdaircr
                            Active Community Member
                            • Aug 2014
                            • 525

                            #28
                            Patch here: http://sprunge.us/bAQX

                            Comment

                            • alasdaircr
                              Active Community Member
                              • Aug 2014
                              • 525

                              #29
                              Weird that it worked for you though, and presumably others too

                              Comment

                              • yuri
                                Member
                                • Mar 2014
                                • 8557

                                #30
                                Nice. Thank you for the fix.
                                If you find EspoCRM good, we would greatly appreciate if you could give the project a star on GitHub. We believe our work truly deserves more recognition. Thanks.

                                Comment

                                Working...